Add psalm template annotation to container get method #30498
Closed
+37
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
requested review from
ChristophWurst,
a team,
nickvergessen,
ArtificialOwl and
CarlSchwan
and removed request for
a team
nickvergessen
approved these changes
Jan 5, 2022
CarlSchwan
approved these changes
Jan 5, 2022
CarlSchwan
reviewed
Jan 6, 2022
|
As I recently discovered, it seems like the |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
CarlSchwan
force-pushed
the
docs/psalm-container
branch
2 times, most recently
from
ac108c4 to
987c53b
Compare
|
I added a commit that fixes the new issues reported by psalm. Please check it :) |
CarlSchwan
force-pushed
the
docs/psalm-container
branch
3 times, most recently
from
bff799b to
e184c31
Compare
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
docs/psalm-container
branch
from
e184c31 to
623865c
Compare
CarlSchwan
reviewed
Jan 14, 2022
| @@ -1974,6 +1984,7 @@ public function getWebRoot() { | |||
| * @deprecated 20.0.0 | |||
| */ | |||
| public function getOcsClient() { | |||
| /** @psalm-suppress UndefinedClass */ | |||
There was a problem hiding this comment.
btw this code looks broken since I couldn't find where the class or alias OcsClient is defined. This, fortunately, doesn't seems to be called anywhere: http://carlschwan.eu:6070/search?q=OcsClient
nickvergessen
approved these changes
Jan 17, 2022
Merged
Merged
Merged
Merged
Merged
|
Obsolete with #33388 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add psalm annotations in order to properly detect the return type of
\OC::$server->get(MyClass::class).Even though DI should be used, this allows to properly get the return type without manually specifiying it when using
get()